
I feel that for its aims it has been pretty successful. I disagree with settler colonialism as a concept but I think they clearly succeeded. Not in every sense perhaps, as not every area has been settler. But they succeeded above and beyond the aims of the early Zionists. It’s an independent Jewish state where Arabs are politically and socially marginalized, with a large system of agricultural kibbutzim, and a high quality of life. And now most of the Jewish diaspora has been relocated there.
Israel put the middle eastern Jews in danger, but by doing that it pushed their migration into its borders, helping to fulfill the Zionist goal. It was less successful in getting the Jewish populations from France, England, and the USA because those are comparatively safe countries. Has been pretty successful in getting the populations from Eastern Europe and to a lesser extent Argentina
They also weren’t successful in completely segregating themselves from Arabs. Early Zionists spoke of wanting a society where Jews are present at every level of economic production, perceiving that as being superior to a South african system of ethnic supremacy. They felt Jews could never be native to the land if they were merely an upper class. This wasn’t paired with a complete expulsion of Arabs but rather an economic and social segregation from them.
Of course it would be inaccurate to act as if all early Zionists had the same goal. There’s the divide between religious and political Zionists and different goals within that. The poor Russian settlers in the ottoman period could hardly be said to be doing it with the goal of expelling Arabs, but the Lehi and Irgun of the 1940s certainly were aligned towards that goal (though only partly followed through).